have you fitted the charge light wire on the right terminal
check to see if the alt is giving you 14.2 volts at the battery when the engine is running
or, strike the engine up, turn lights on
then leaving the lights on, switch the engine off
do the lights dim or stay the same ?
this will tell you if it is charging or not
swapping diode/brush packs wont make any odds to the charge light
dan